task(TP-196, TP-197): stage segment-engine hardening + dashboard-progress packets#576
Merged
Merged
Conversation
…ress packets Triage closure of the 5 segment-related issues that survived the #51 closure (because they're polish/hardening, not core feature work): - #462: Harden .DONE authority for multi-segment tasks → TP-196 - #502: SegmentScopeMode single enum gating all signals → TP-196 - #503: Regression tests for SegmentScopeMode prompt injection → TP-196 - #508: Lane-runner segment completion check before respawn → TP-196 - #464: Dashboard segment-level progress indicators → TP-197 All 5 issues triaged as still relevant (none obsolete). Grouped into 2 task packets by file-scope cohesion: ## TP-196 — Multi-segment engine hardening (#462, #502, #503, #508) Size M, Review Level 2 (Plan + Code), per-step reviews. All four issues overlap heavily in lane-runner.ts, execution.ts, resume.ts, discovery.ts. Sequencing within the task: - Step 2: #502 first (foundational SegmentScopeMode promotion) - Step 3: #462 (.DONE authority guards built atop #502's flag) - Step 4: #508 (early-exit optimization) - Step 5: #503 (regression tests covering #502/#503 surfaces) ## TP-197 — Dashboard segment-level progress indicators (#464) Size S-M, Review Level 1 (Plan Only). Kept separate from TP-196: - Different file domain: dashboard/public/ (vanilla JS, intentionally out of Biome lint scope per code-quality-gates spec section 3) - Different validation approach: manual visual verification vs. unit-test-driven - Different reviewer level historically (UX-only changes are Level 1) - No file overlap with TP-196's scope ## CONTEXT.md Next Task ID bumped TP-196 → TP-198. The unassigned Tier-1.5 follow-ups (TS strictness ratchet, CHANGELOG fragments) per the code-quality-gates spec will claim TP-198 / TP-199 when staged. ## Issue comments posted Each of the 5 issues received a triage-update comment explaining which TP absorbs the work and why. Will auto-close when the absorbing PRs merge. ## Discovery probe 0 errors, 2 pending tasks, 0 deps. Ready for /orch when scheduled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triage closure of the 5 segment-related issues that survived the #51 closure (because they're polish/hardening, not core feature work).
Triage results — all 5 still relevant
.DONEauthority for multi-segment tasksNone obsolete. All in active relevance to the shipped multi-repo task execution machinery.
Grouping rationale
TP-196 absorbs 4 issues — multi-segment engine hardening
All 4 touch overlapping files:
lane-runner.ts,execution.ts,resume.ts,discovery.ts,segment-scoped-lane-runner.test.ts. They share the segment-engine mental model. Bundling lets the worker reuse the context once and ship a coherent hardening pass.Sequencing within the task:
SegmentScopeModeto a first-class type. This creates the authoritative flag that the other fixes can also reference..DONEauthority guards (monitor + resume + discovery), built atop Segment scope mode should be a single enum gating all segment signals #502's flag.Size M, Review Level 2 (Plan + Code), per-step reviews.
TP-197 absorbs #464 — dashboard segment-progress indicators
Pure UX work in
dashboard/public/files. Different domain, different validation approach (manual visual verification vs. unit-test-driven), different reviewer level historically (UX-only is Level 1). No file-scope overlap with TP-196.Size S-M, Review Level 1 (Plan Only).
What's in this PR
taskplane-tasks/TP-196-multi-segment-engine-hardening/PROMPT.md(~12 KB)taskplane-tasks/TP-196-multi-segment-engine-hardening/STATUS.md(~5 KB)taskplane-tasks/TP-197-dashboard-segment-progress/PROMPT.md(~10 KB)taskplane-tasks/TP-197-dashboard-segment-progress/STATUS.md(~4 KB)taskplane-tasks/CONTEXT.md— Next Task ID bumped TP-196 → TP-198What's NOT in this PR
Issue comments posted
Each of the 5 issues received a triage-update comment naming the absorbing TP. Will auto-close when the absorbing PRs merge.
Validation
Pure docs + task-folder files. No code, no tests, no version bump. CI should pass on existing suite trivially.
Discovery probe: 0 errors, 2 pending tasks, 0 declared deps. Ready for
/orchwhen scheduled.