Verify: BIGINT columns return Python int (legacy #63)#33
Merged
HenryNebula merged 5 commits intodevfrom Apr 24, 2026
Merged
Conversation
Legacy bug: BIGINT values returned as raw jpype._jclass.java.lang.Long objects instead of Python ints. Dodged in our Arrow-based path which handles BIGINT natively via Int64 type. Add mockBigIntResult() helper to MockConnection and regression tests covering edge cases: 0, -1, Long.MAX_VALUE, Long.MIN_VALUE. Closes #32 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Oracle does not support BIGINT as a SQL type (uses NUMBER instead). Drill does not support CREATE TABLE with BIGINT. Add skipTest for these database-specific test classes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
testsuite.py appends a tox env suffix to class names (e.g. OracleTest_py314-driver-oracle), so exact match fails. Use startswith() instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The initial commit accidentally included DOUBLE-related tests (test_double_column_returns_float, test_double_type_returns_float, test_double_edge_values) and mockDoubleResult() helper that belong in PR #25 (legacy #243). These caused CI failures on MSSQL where DOUBLE is not a valid T-SQL type. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
c819429 to
a539727
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32: Verifies legacy baztian/jaydebeapi#63 (BIGINT not converted to Python int) is dodged in jaydebeapiarrow.
The legacy bug caused BIGINT values to be returned as raw
jpype._jclass.java.lang.Longobjects instead of Pythonint. Our Arrow-based path handles BIGINT natively via Arrow'sInt64type, avoiding this entirely.Changes
mockBigIntResult(long)helper toMockConnectionfor configurable BIGINT mockingintTest plan
Closes #32
Generated with Claude Code