fix: restore table view in pipeline execution screens#2
Merged
HenryOwenz merged 1 commit intomainfrom Mar 14, 2025
Merged
Conversation
This commit fixes an issue where the pipeline approval and start pipeline execution views were showing a 'loading...' message instead of the expected table with 'Execute' and 'Cancel' options. The issue was in the renderMainContent function in internal/ui/view/view.go, which was returning m.LoadingMsg for the ViewExecutingAction view instead of rendering the table. The fix changes the function to call renderTable(m) instead, which properly displays the table with execution options. Added regression tests: - Unit test in view_test.go to verify the renderMainContent function correctly renders a table - Enhanced integration tests in aws_pipeline_start_test.go and aws_approvals_test.go to verify the table is displayed correctly This ensures the execution view will continue to display properly in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the pipeline approval and start pipeline execution views were showing a 'loading...' message instead of the expected table with 'Execute' and 'Cancel' options. The issue was in the renderMainContent function in internal/ui/view/view.go, which was returning m.LoadingMsg for the ViewExecutingAction view instead of rendering the table. The fix changes the function to call renderTable(m) instead, which properly displays the table with execution options.
Added regression tests:
This ensures the execution view will continue to display properly in the future.