Skip to content

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Feb 6, 2018

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Add missing variables into login interface.
Add interface into account.c.
Add interface into ipban.c.
Create lchrif interface in login.c
Add interface into loginlog.c.

Issues addressed:

Fixes issue #1908

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@4144 4144 force-pushed the fix1908 branch 2 times, most recently from 75327c1 to ca31d6f Compare February 6, 2018 22:51
@4144 4144 added the status:code-review Awaiting code review label Feb 6, 2018
@4144 4144 added this to the Release v2018.02.11 milestone Feb 6, 2018
Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna merged commit 6f85e39 into HerculesWS:master Feb 10, 2018
@4144 4144 deleted the fix1908 branch February 10, 2018 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code-review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants