Skip to content

Conversation

@4144
Copy link
Contributor

@4144 4144 commented Feb 22, 2018

Pull Request Prelude

  • I have followed [proper Hercules code styling][code].
  • I have read and understood the [contribution guidelines][cont] before making this PR.
  • I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Fix md5 calculation for binary strings.

Warning: after this fix need regenerate map cache.

@HerculesWSAPI
Copy link
Contributor

This change is Reviewable

@4144 4144 added the status:code-review Awaiting code review label Feb 23, 2018
@4144 4144 added this to the Release v2018.03.11 milestone Feb 23, 2018
@MishimaHaruna
Copy link
Member

For convenience (since the diff of binary files is not displayed here), here's the content of commit f0d620e: https://gist.github.com/MishimaHaruna/568e6e93084f2aee34da3642e77be18e (generated using hexdump -e '18/1 "%02x " "\n"' as diff filter - line length tweaked to fit the entire md5 binary data on the first line of each diff)

4144 and others added 3 commits March 9, 2018 03:19
The function is part of the mapcache plugin, called through the
`--fixmd5` flag. It will update all the maps that would be loaded by the
map server (as listed in map_index.txt).

This also fixes a memory leak in the mapcache plugin.

Signed-off-by: Haru <haru@dotalux.com>
Signed-off-by: Haru <haru@dotalux.com>
@MishimaHaruna MishimaHaruna merged commit 69377ed into HerculesWS:master Mar 11, 2018
@4144 4144 deleted the fixmd5 branch March 11, 2018 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code-review Awaiting code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants