Convert Pet db to Libconfig #2000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
Asheraf
force-pushed
the
petdb
branch
5 times, most recently
from
f680b82 to
7dbc431
Compare
Asheraf
added
component:databases
Asheraf
force-pushed
the
petdb
branch
2 times, most recently
from
140abdb to
9556275
Compare
4144
requested changes
Mar 28, 2018
| bool pet_read_db_sub_intimacy(int idx, struct config_setting_t *t) | ||
| { | ||
| int i32 = 0; | ||
|
|
Asheraf
force-pushed
the
petdb
branch
3 times, most recently
from
502a51a to
d09e8fc
Compare
4144
approved these changes
Mar 28, 2018
|
You can implement pet evolution? |
MishimaHaruna
requested changes
Apr 7, 2018
| //========================================================================= | ||
|
|
||
| pet_db:( | ||
| // entries in this file will override the ones in /(pre-)re/pet_db.conf |
Member
There was a problem hiding this comment.
Can you add the comment with the documentation about the existing keys and their meaning? (the same as in the other two .conf files)
| ChangeTargetRate: change target (int, defaults to 0) | ||
| PetScript: <" Pet Script (can also be multi-line) "> | ||
| EquipScript: <" Equip Script (can also be multi-line) "> | ||
| }, |
Member
There was a problem hiding this comment.
I'd like to use this chance to change the spelling of some of these keys (because it gets more annoying to do this later, once people have converted their databases). My suggested keys are:
Id: Ok.SpriteName: OkName: OkTamingItemID: I'd shorten this toTamingItemto hint that we don't ask for a numberEggItemID: As above,EggItemAccessoryItemID: As above,AccessoryItemFoodItemID: As above,FoodItemFullness: I'd change this to the more meaningfulFoodEffectivenessHungryDelay: I'd correct this toHungerDelayIntimacy/Start: I'd perhaps change this toIntimacy/Initial, orIntimacy/Startingif you preferIntimacy/Feed: I'd clarify this asIntimacy/FeedIncrementIntimacy/OverFeed: Same as above,Intimacy/OverFeedDecrementIntimacy/OwnerDie: Same as above,Intimacy/OwnerDeathDecrementCaptureRate: OkSpeed: OkSpecialPerformance: OkTalkConvertClass: This should probably be a boolean, namedTalkWithEmotesorUseEmotesAttackRate: OkDefenceAttackRate: Should be corrected toDefendRate(considering "attack" above as a verb)ChangeTargetRate: OkPetScript: OkEquipScript: Ok
you can use this tool as follows ./petdbconverter.py re ../ ../db/re/pet_db.txt > pet_db.conf or for pre-re mode ./petdbconverter.py pre-re ../ ../db/pre-re/pet_db.txt > pet_db.conf
MishimaHaruna
approved these changes
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Known Issues and TODO List