Summary
The private function is named Convert-ToTypeValue (no d). The test file, call site in Test-Condition.ps1, and every other function in the module (e.g., Test-TypedValue) use Typed. The source file and function declaration are the odd ones out.
Files Affected
| File |
Change |
Gatekeeper/Private/Convert-ToTypeValue.ps1 |
Rename file to Convert-ToTypedValue.ps1 |
Gatekeeper/Private/Convert-ToTypeValue.ps1:1 |
Rename function declaration from Convert-ToTypeValue to Convert-ToTypedValue |
Gatekeeper/Gatekeeper.psm1 |
Update dot-source path if hardcoded |
tests/Convert-ToTypedValue.tests.ps1 |
Already correct — no change needed |
Notes
- Good first issue
- The call site
Test-Condition.ps1:88 already uses Convert-ToTypedValue — so either the function name was wrong from the start, or it was renamed without updating the source file
- Found by Brent Tlackburn and Shawn Wee!-ler
Summary
The private function is named
Convert-ToTypeValue(nod). The test file, call site inTest-Condition.ps1, and every other function in the module (e.g.,Test-TypedValue) useTyped. The source file and function declaration are the odd ones out.Files Affected
Gatekeeper/Private/Convert-ToTypeValue.ps1Convert-ToTypedValue.ps1Gatekeeper/Private/Convert-ToTypeValue.ps1:1Convert-ToTypeValuetoConvert-ToTypedValueGatekeeper/Gatekeeper.psm1tests/Convert-ToTypedValue.tests.ps1Notes
Test-Condition.ps1:88already usesConvert-ToTypedValue— so either the function name was wrong from the start, or it was renamed without updating the source file