Skip to content

refactor: rename Convert-ToTypeValue to Convert-ToTypedValue (missing 'd') #34

@HeyItsGilbert

Description

@HeyItsGilbert

Summary

The private function is named Convert-ToTypeValue (no d). The test file, call site in Test-Condition.ps1, and every other function in the module (e.g., Test-TypedValue) use Typed. The source file and function declaration are the odd ones out.

Files Affected

File Change
Gatekeeper/Private/Convert-ToTypeValue.ps1 Rename file to Convert-ToTypedValue.ps1
Gatekeeper/Private/Convert-ToTypeValue.ps1:1 Rename function declaration from Convert-ToTypeValue to Convert-ToTypedValue
Gatekeeper/Gatekeeper.psm1 Update dot-source path if hardcoded
tests/Convert-ToTypedValue.tests.ps1 Already correct — no change needed

Notes

  • Good first issue
  • The call site Test-Condition.ps1:88 already uses Convert-ToTypedValue — so either the function name was wrong from the start, or it was renamed without updating the source file
  • Found by Brent Tlackburn and Shawn Wee!-ler

Metadata

Metadata

Assignees

No one assigned

    Labels

    refactorCode quality, structure, or naming

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions