fix(validation): remove duplicate Test-TypedValue helper#71
Merged
Conversation
Test-TypedValue duplicated integer/string min/max/length/pattern logic already implemented in PropertyDefinition.Validate, with a divergent contract (throws vs Write-Warning + bool return). It was unreferenced in the module — only its own tests exercised it. Test-Condition already routes through PropertyDefinition.Validate, so removing the helper collapses validation to a single canonical contract. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
HeyItsGilbert
force-pushed
the
worktree-tingly-twirling-pascal
branch
from
01385cb to
200cf6a
Compare
Test Results 4 files 436 suites 13s ⏱️ Results for commit 200cf6a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36.
Summary
Test-TypedValue(private helper) and its tests. The function duplicated integer/string min/max/length/pattern checks already implemented inPropertyDefinition.Validate, with a divergent contract (throws vsWrite-Warning+ bool).Test-Conditionalready routes validation throughPropertyDefinition.Validateand uses the returned bool (Test-Condition.ps1:94-95), so removal collapses validation to one canonical contract.CLAUDE.mdto drop the reference to the removed helper.Test plan
./build.ps1 -Task Test -OutputFormat Quiet— 360 passed, 0 failed, 5 skipped