Skip to content

dev: moved current datetime to toolbar as a widget#1172

Merged
KernelDeimos merged 2 commits intoHeyPuter:mainfrom
sashpawar11:feat-clock
Mar 13, 2025
Merged

dev: moved current datetime to toolbar as a widget#1172
KernelDeimos merged 2 commits intoHeyPuter:mainfrom
sashpawar11:feat-clock

Conversation

@sashpawar11
Copy link
Copy Markdown
Contributor

@sashpawar11 sashpawar11 commented Mar 13, 2025

This PR creates the initial implementation for #1171.

ChangeLog

  • Current clock element has been moved to the toolbar under UIDesktop with other toolbar buttons
  • display_ct() under UIDesktop has been tweaked to display a better/sleek datetimestamp
  • window.change_clock_visible intialization on DOM load has been moved to UIDesktop due to DOM element accessibility bug

New Toolbar Clock UI:
image

Puter Desktop View:
image

@sashpawar11
Copy link
Copy Markdown
Contributor Author

sashpawar11 commented Mar 13, 2025

@KernelDeimos @jelveh - here's the initial PR for the proposed enhancement under #1171

@KernelDeimos
Copy link
Copy Markdown
Contributor

Thanks, this implementation is very straightforward. No comments, I'm merging it now.

@KernelDeimos KernelDeimos merged commit 672e2e7 into HeyPuter:main Mar 13, 2025
@sashpawar11
Copy link
Copy Markdown
Contributor Author

Shesh , thanks @KernelDeimos !

@KernelDeimos
Copy link
Copy Markdown
Contributor

This PR introduced unexpected movement of other icons on the upper bar when the clock is visible. It was a simple fix so I fixed that on main. Here's the commit if you'd like to review it: 8edcf75

@sashpawar11
Copy link
Copy Markdown
Contributor Author

@KernelDeimos - apologies, missed that. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants