Skip to content

Fix npm install error on Windows (spawn EINVAL) (#1203)#1214

Merged
KernelDeimos merged 1 commit intoHeyPuter:mainfrom
kristavlastou:main
Mar 26, 2025
Merged

Fix npm install error on Windows (spawn EINVAL) (#1203)#1214
KernelDeimos merged 1 commit intoHeyPuter:mainfrom
kristavlastou:main

Conversation

@kristavlastou
Copy link
Copy Markdown
Contributor

Resolved an issue where spawn('npm', ['install']) failed on Windows due to npm being a batch script.

  • Updated Kernel.js to determine the correct npm command based on the OS.
  • Now uses npm.cmd on Windows and npm otherwise.

This ensures npm install runs correctly across all operating systems.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 24, 2025

CLA assistant check
All committers have signed the CLA.

@DarkCodeStudios

This comment was marked as abuse.

@kristavlastou
Copy link
Copy Markdown
Contributor Author

Thank you for your feedback but I cannot spot the duplicated proc declaration as I declare it only in line 403 as I modified only 2 lines in the function. Also Vscode also doesn't point out any Syntax error. Can you explain it further?

@KernelDeimos
Copy link
Copy Markdown
Contributor

@DarkCodeStudios is it possible you misinterpreted the diff? I don't see a duplication declaration either.

image

@DarkCodeStudios

This comment was marked as abuse.

@KernelDeimos KernelDeimos merged commit 4b7e09e into HeyPuter:main Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants