Skip to content

Add Remove profile picture button #1245#1246

Merged
KernelDeimos merged 2 commits intoHeyPuter:mainfrom
EvaNtziou:branch2
Apr 4, 2025
Merged

Add Remove profile picture button #1245#1246
KernelDeimos merged 2 commits intoHeyPuter:mainfrom
EvaNtziou:branch2

Conversation

@EvaNtziou
Copy link
Copy Markdown
Contributor

Adding the feature of issue #1245

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Contributor

@KernelDeimos KernelDeimos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reviewed the code and have no comments - seems straightforward and I don't notice any issues. I plan to do a manual test by end of week. Thanks for the contribution!

@KernelDeimos
Copy link
Copy Markdown
Contributor

I seem to be getting a layout issue during manual testing. Are you able to reproduce this?
image

@EvaNtziou
Copy link
Copy Markdown
Contributor Author

you are right, sorry! I accidentally deleted "h += </div>;" in line 57 of UITabAccount.js . Should i make a new pull request with the added line?

@KernelDeimos
Copy link
Copy Markdown
Contributor

you are right, sorry! I accidentally deleted "h += </div>;" in line 57 of UITabAccount.js . Should i make a new pull request with the added line?

You should be able to commit to the branch that this PR is tracking, and the PR will "update" automatically.

@KernelDeimos
Copy link
Copy Markdown
Contributor

Perfect - thanks!

@KernelDeimos KernelDeimos merged commit dad72c5 into HeyPuter:main Apr 4, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants