Skip to content

captcha: imporve condition checks for cloudflare turnstile#1469

Merged
jelveh merged 4 commits intoHeyPuter:mainfrom
XiaochenCui:captcha
Aug 28, 2025
Merged

captcha: imporve condition checks for cloudflare turnstile#1469
jelveh merged 4 commits intoHeyPuter:mainfrom
XiaochenCui:captcha

Conversation

@XiaochenCui
Copy link
Copy Markdown
Contributor

@XiaochenCui XiaochenCui commented Aug 28, 2025

This PR is a continue of #1129

  • Add checks for "enabled" is false.
  • Fix checks in the frontend, make signup works when "cloudflare turnstile" turned off. (Tested manually)

The next step is to:

  • make the "cloudflare turnstile" widget invisible since the signup window is already crowded
  • finish the docs

@XiaochenCui
Copy link
Copy Markdown
Contributor Author

@jelveh @ProgrammerIn-wonderland this PR is ready for review/merge

@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Aug 28, 2025

this is conflicting now. I want to wait until the second part (as mentioned in description) is implemented as well before I go for full review

@XiaochenCui XiaochenCui marked this pull request as draft August 28, 2025 20:21
@XiaochenCui
Copy link
Copy Markdown
Contributor Author

this is conflicting now. I want to wait until the second part (as mentioned in description) is implemented as well before I go for full review

Do you mean the invisible widget for captach? I'll open this PR when that's implemented

@XiaochenCui XiaochenCui marked this pull request as ready for review August 28, 2025 22:00
@XiaochenCui
Copy link
Copy Markdown
Contributor Author

now it's ready for review/merge, I set the widget to invisible when verification success

@jelveh jelveh merged commit 0c39f83 into HeyPuter:main Aug 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants