Skip to content

Add context menu to apps in the start menu#1487

Merged
jelveh merged 10 commits intoHeyPuter:mainfrom
bomberfish:start-menu-context
Sep 21, 2025
Merged

Add context menu to apps in the start menu#1487
jelveh merged 10 commits intoHeyPuter:mainfrom
bomberfish:start-menu-context

Conversation

@bomberfish
Copy link
Copy Markdown
Member

No description provided.

@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Sep 6, 2025

If I right-click on two items consecutively this happens:

Screenshot 2025-09-06 at 10 25 41 AM

@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Sep 6, 2025

ahhh! I just realized this was a draft PR. I'll wait for the final version

@bomberfish bomberfish marked this pull request as ready for review September 9, 2025 01:15
@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Sep 9, 2025

One issue I noticed; when the user right click on a launch menu item, the "active state" is removed from the item i.e. it's not highlighted any longer.

Mouse over item (highlighted):
Screenshot 2025-09-08 at 6 14 11 PM

Right-click (highlight/active state removed):
Screenshot 2025-09-08 at 6 14 51 PM

This is confusing to the user as once the menu is opened, the connection between menu and item is basically removed.

@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Sep 10, 2025

When the context menu is opened the active state is now correctly preserved, but when the context menu is closed the active state isn't removed.

@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Sep 10, 2025

if you open a context menu anywhere else on the desktop and then open the new launch menu context menu the shadow behind it is much more pronounced

@jelveh
Copy link
Copy Markdown
Contributor

jelveh commented Sep 13, 2025

There is some extra space that shows up to the right and bottom of the launcher, randomly. I can't reproduce it consistently right now but it does show up.
Screenshot 2025-09-12 at 6 04 07 PM

@ProgrammerIn-wonderland
Copy link
Copy Markdown
Collaborator

image

Just to add it to a todo, clicking on white space shows the browser native context menu, I think this should be supressed

@jelveh jelveh merged commit 3de3c21 into HeyPuter:main Sep 21, 2025
4 checks passed
Salazareo pushed a commit that referenced this pull request Sep 25, 2025
* Add context menu to apps in the start menu

* Start menu context menus: Close other menus

* More bugfixes for start menu context menus

* Start menu context menus: Add/remove from taskbar

* Bugfixes for adding to taskbar through start menu

* Highlight start menu icons when ctxmenu is opened

* Close context menus on start menu kbd navigation

* Reset start menu icon state when ctx menu closed

* Fix multiple start item context menus opening simultaneously

* Remove parent argument from start icon context menus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants