fix puterjs throwing errors after consuming message events not meant for it#1612
Merged
jelveh merged 2 commits intoHeyPuter:mainfrom Sep 25, 2025
Merged
fix puterjs throwing errors after consuming message events not meant for it#1612jelveh merged 2 commits intoHeyPuter:mainfrom
jelveh merged 2 commits intoHeyPuter:mainfrom
Conversation
Salazareo
pushed a commit
that referenced
this pull request
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
puter.js uses message events to communicate between the Puter GUI and the app. However, not all message events that puterjs receives are sent from the GUI, they can be sent by the app itself, a subframe of the app, or even an external browser extension messaging with a content script (this is quite common). Other than these cases that I fixed, puter generally checks for the existence of
msganderrorbefore doing anything with the data, so it isn't a huge deal. The keymsgis somewhat common though, so there's still a chance of it consuming messages that weren't sent from the GUI. There could probably be a namespaced key likeputer_messageso that this doesn't happen again in the future. I didn't implement this here because there's quite a few places where postmessage was used and there's no abstraction over it so it would get messy, but if that section is ever rewritten or revisited this should be kept in mind