[puterfs] move write operations to extension#1940
Merged
KernelDeimos merged 4 commits intomainfrom Nov 11, 2025
Merged
Conversation
FileCacheService was still a legacy service extending AdvancedBase. This commit changes it to extend BaseService and implement the lifecycle methods consistent with other services. This is a prerequisite for moving write_overwrite which needs to import the service via `extension.import` (not possible for legacy services) so that it may invalidate file cache when a file is written to.
KernelDeimos
force-pushed
the
25B70-write-operations
branch
from
770e20b to
0d947be
Compare
Contributor
Author
|
I'm going to merge this Tuesday morning in case any issues come up. I have another branch ready that depends on this but I want these changes to go into prod first, because the migration is now entering the parts where the risk of breaking changes is relatively high. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.