Conversation
| if ( jaeger ?? this.config.jaeger ) { | ||
| return new OTLPTraceExporter(jaeger ?? this.config.jaeger); | ||
| } | ||
| if ( this.config.devConsole ) { |
Contributor
There was a problem hiding this comment.
I would just call this console rather than devConsole
|
|
||
| const exporter = this.#getConfiguredExporter(); | ||
| this.exporter = exporter; | ||
| const metrictExporter = this.#getMetricExporter(); |
Contributor
There was a problem hiding this comment.
Should this be metricExporter?
|
|
||
| module.exports = TelemetryService; | ||
| #getMetricExporter () { | ||
| if ( jaeger ?? this.config.jaeger ) { |
Contributor
There was a problem hiding this comment.
What is jaeger here? config.jaeger was much clearer. Maybe we should remove support for a global config entry for this - I don't think anybody else was using this.
Salazareo
force-pushed
the
DS/main
branch
3 times, most recently
from
2fb5d60 to
b0e2fde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.