Skip to content

Fix workers types#2198

Merged
Salazareo merged 1 commit intoHeyPuter:mainfrom
reynaldichernando:fix-workers-types
Dec 23, 2025
Merged

Fix workers types#2198
Salazareo merged 1 commit intoHeyPuter:mainfrom
reynaldichernando:fix-workers-types

Conversation

@reynaldichernando
Copy link
Copy Markdown
Member

@reynaldichernando reynaldichernando commented Dec 18, 2025

  • adjust WorkerInfo and WorkerDeployment property
  • adjust get return type
  • adjust getLoggingHandle return type

note:

  • i don't document getLoggingHandle, i assume this is internal
  • onLog doesn't seem to do anything in the implementation, although still adding it for now
  • lmk if onLog is not needed

@reynaldichernando
Copy link
Copy Markdown
Member Author

reynaldichernando commented Dec 18, 2025

error is admin password again 🤔

@reynaldichernando
Copy link
Copy Markdown
Member Author

reynaldichernando commented Dec 22, 2025

hi @Salazareo , could you help to review this PR, thank you 🙏

@Salazareo Salazareo merged commit a32a16d into HeyPuter:main Dec 23, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Salazareo Salazareo Salazareo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reynaldichernando @Salazareo