fix(backend): race condition in hashing_stream#2263
Merged
KernelDeimos merged 1 commit intomainfrom Jan 10, 2026
Merged
Conversation
Based on a stack trace from production and manual static analysis, it appears that a race condition occurs within hashing_stream intermittently. The conditions that cause this issue might be heavy backpressure. The source stream emits the 'end' event before stream.Transform's transform callback has had a chance to process all of the chunks, which results in an incorrect order in calling methods on the `typeof crypto.createHash()` object. It would appear that `source.pipe(stream)` is not able to propagate errors from Transform because the chain was simply broken and upload would get stuck (if this was indeed the cause of upload getting stuck, which seems likely but not conclusive)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on a stack trace from production and manual static analysis, it appears that a race condition occurs within hashing_stream intermittently. The conditions that cause this issue might be heavy backpressure. The source stream emits the 'end' event before stream.Transform's transform callback has had a chance to process all of the chunks, which results in an incorrect order in calling methods on the
typeof crypto.createHash()object.It would appear that
source.pipe(stream)is not able to propagate errors from Transform because the chain was simply broken and upload would get stuck (if this was indeed the cause of upload getting stuck, which seems likely but not conclusive)