Prevent puter.fs.write from failing on concurrent writes#2287
Merged
KernelDeimos merged 3 commits intomainfrom Jan 15, 2026
Merged
Prevent puter.fs.write from failing on concurrent writes#2287KernelDeimos merged 3 commits intomainfrom
puter.fs.write from failing on concurrent writes#2287KernelDeimos merged 3 commits intomainfrom
Conversation
Handle a race condition affecting mkdir operations with the `createMissingParents` option enabled. When creating a directory because this option was specified, errors because the directory already exists are likely due to a race condition and should not be propagated to the client but instead handled by using the directory that's already there.
Extract common behavior from MkTree and QuickMkdir to a separate method which is user by both operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make parallel write operations with
createMissingParentsmore robust.Testing checklist for this PR:
await puter.fs.mkdir('/user/some_dir')to verify basic directory creation still worksawait puter.fs.mkdir('/user/a/b/c')when/user/adoes not exist to verifycreateMissingParentsis still requiredawait puter.fs.mkdir('/admin/a/b/c', { createMissingParents: true })to verify recursive directory creation still works