Fixes related to apps driver (replacement for es:apps)#2308
Merged
KernelDeimos merged 2 commits intomainfrom Jan 20, 2026
Merged
Fixes related to apps driver (replacement for es:apps)#2308KernelDeimos merged 2 commits intomainfrom
apps driver (replacement for es:apps)#2308KernelDeimos merged 2 commits intomainfrom
Conversation
The permission implicator for protected apps was written before changes to the permission system that affect the conditions under which a user is allowed to grant and revoke permissions; specifically this is the `manage:` set of permissions, which now needs to be granted to the owner of a protected app. Additionally, the "level" component of the permission is ignored because the owner of a protected all is implied to have all the permissions pertaining to that protected app.
The "flat" implementation of permissions was broken because revokePermission tried to delete entries by calling `.set` with an option called "delete". I'm not sure if this has ever existed on the puter-kvstore interface, so it's weird that it was called like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fixes were going to go in the branch for #2219 but it became clear that these are issues affecting
maincurrently even without that change. The biggest issue is a bug affectingrevokePermission- it doesn't work right now.