fix: app-under-user access token ACL#2367
Merged
KernelDeimos merged 1 commit intomainfrom Jan 28, 2026
Merged
Conversation
There were a couple issues with ACL where access would be denied to app tokens within access tokens, caused by: - incorrect recursion: only `false` was considered when in fact the result from the recursive call is appropriate - files without a known path are incorrectly handled, which can happen when iterating over parent directories
Contributor
Author
|
Backend tests are currently broken from 89c4990 so I'm merging this because the test errors are still consistent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a couple issues with ACL where access would be denied to app tokens within access tokens, caused by:
falsewas considered when in fact the result from the recursive call is appropriate