Add permission requests for directories of subdomains associated with apps owned by the user#2507
Merged
KernelDeimos merged 4 commits intomainfrom Feb 18, 2026
Merged
Conversation
Add the ability to request an app's root directory. A permission rewriter is provided so that apps may refer to a permission when requesting this access without knowing the path of the app's root directory.
Add support for requesting access to the root directory of an app's associated subdomain.
Fix ESM/CJS interop issue in unit tests with a hack that checks the class name as a string instead of just doing an `instanceof` check. This is assuming that the "rewriter must be a PermissionRewriter" error I'm seeing on GitHub is because there are two different "copies" of PermissionWriter due to ESM/CJS interop issues. If this is not the case, then you're not reading this commit message on `main`; if this commit is on `main` then that's exactly what went down.
Contributor
Author
|
I hate ESM/CJS interop soooo much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows an app to request permission to access the directory for one of the user's apps. The user must have permission to access the directory in order for the app to have permission. The subdomain associated with the app is determined in one of two ways:
Permission is checked primarily based on filesystem permission of the directory. App ownership is also checked as an additional precaution.