fix: bad copy with reference in UIItem#2526
Merged
KernelDeimos merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
UIItem makes a recursive call when there are multiple matching elements in the `options.appendTo` argument. When calling recursively, the `appendTo` property of the `options` object is mutated to a specific element before the call, which expects that each call to UIItem occurs synchronously. UIItem was made asynchronous by 9d598f7 which resulted in a bug causing duplicate item icons in one directory window instead of one item icon in each directory window after a file upload when multiple instances of a window at the same directory location exist. Resolves #2514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIItem makes a recursive call when there are multiple matching elements in the
options.appendToargument. When calling recursively, theappendToproperty of theoptionsobject is mutated to a specific element before the call, which expects that each call to UIItem occurs synchronously. UIItem was made asynchronous by9d598f7
which resulted in a bug causing duplicate item icons in one directory window instead of one item icon in each directory window after a file upload when multiple instances of a window at the same directory location exist.
Resolves #2514