fix(oidc): login flow with puter.ui.authenticateWithPuter#2588
Merged
KernelDeimos merged 1 commit intomainfrom Mar 4, 2026
Merged
fix(oidc): login flow with puter.ui.authenticateWithPuter#2588KernelDeimos merged 1 commit intomainfrom
puter.ui.authenticateWithPuter#2588KernelDeimos merged 1 commit intomainfrom
Conversation
It turns out there are nuances between `puter.ui.authenticateWithPuter` vs `puter.auth.signIn` - these don't do the same thing. The primary difference is that `puter.ui.authenticateWithPuter` will display an override if it's not triggered by a user action, whereas `puter.auth.signIn` will not. This definitely suggests `puter.ui.authenticateWithPuter` should be a caller of `puter.auth.signIn` instead of implementing its own logic for handling the popup - that makes this part of the code more fagile - but that refactor is out-of-scope for this bug fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out there are nuances between
puter.ui.authenticateWithPutervsputer.auth.signIn- these don't do the same thing. The primary difference is thatputer.ui.authenticateWithPuterwill display an override if it's not triggered by a user action, whereasputer.auth.signInwill not. This definitely suggestsputer.ui.authenticateWithPutershould be a caller ofputer.auth.signIninstead of implementing its own logic for handling the popup - that makes this part of the code more fagile - but that refactor is out-of-scope for this bug fix.