Skip to content

fix(oidc): request object reference in oidc signup #2598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KernelDeimos merged 1 commit into from
Mar 4, 2026
Merged

fix(oidc): request object reference in oidc signup #2598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/backend/src/services/auth/SignupService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import bcrypt from 'bcrypt';
import { v4 as uuidv4 } from 'uuid';
import { generate_random_username, send_email_verification_code, send_email_verification_token, username_exists } from '../../helpers.js';
import { Context } from '../../util/context.js';
import { OutcomeObject } from '../../util/outcomeutil.js';
import { validate_nonEmpty_string } from '../../util/validutil.js';
import BaseService from '../BaseService.js';
Expand All @@ -19,7 +20,9 @@ export class SignupService extends BaseService {
* Creates a new user.
* @async
* @param {object} params - The parameters for creating a new user.
* @param {object} [params.req] - The request object (if applicable).
* @param {object} [params.req] - The request object. If not specified,
* the request will be obtained from the context. If specified as null, request
* information will not be included for this signup.
* @param {boolean} [params.temporary] - Whether the user is a temporary user.
* @param {boolean} [params.oidc_only] - Whether the user created with OIDC
* @param {boolean} [params.send_confirmation_code] - Whether to send a confirmation code instead of a token by email
Expand All @@ -41,6 +44,10 @@ export class SignupService extends BaseService {
}) {
const outcome = new OutcomeObject(new CreatedUserOutcome());

if ( !req && req !== null ) {
req = Context.get('req');
}

let raw_email = email;

if ( ! username ) {
Expand Down
Loading