clean(apps): merge fns only called by get_app_icon_url#2617
Merged
KernelDeimos merged 1 commit intomainfrom Mar 7, 2026
Merged
clean(apps): merge fns only called by get_app_icon_url#2617KernelDeimos merged 1 commit intomainfrom
KernelDeimos merged 1 commit intomainfrom
Conversation
Each of these methods is only being called by get_app_icon_url. By changing that ternary operator into an `if` block with an early return we can move the bodies of these functions here. If one of the former functions ever needs to be used in more than one place, it's easy to extract it out of here agian - for now though let's not pay the cost of jumping to another function definition while trying to understand this code if we're not gaining anything from it.
Contributor
Author
|
I wanted to add more to this PR but I'll get this in for now and PR further changes later, since this approach reduces the chances of a merge conflict in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of these methods is only being called by get_app_icon_url. By changing that ternary operator into an
ifblock with an early return we can move the bodies of these functions here. If one of the former functions ever needs to be used in more than one place, it's easy to extract it out of here agian - for now though let's not pay the cost of jumping to another function definition while trying to understand this code if we're not gaining anything from it.