Fix missing password entry#2632
Merged
KernelDeimos merged 4 commits intomainfrom Mar 10, 2026
Merged
Conversation
This reverts commit 468558f.
Earlier this was removed with a simple `display: none` in CSS to avoid changing any logic, and the reason for that was OIDC had already gone through significant testing, re-testing, and bug fixes; it became clear that changes to the auth flow are fragile and the test surface is very large. Now unfortunately what seemed like a smart decision to fix a cosmetic issue with CSS instead of updating logic actually wound up breaking the change username/password flow for non-OIDC users. This commit removes this box properly and hopefully does not introduce a subsequent terrible bug. Why would it? There's absolutely no reason I can see that it would, but it would seem that nothing is safe, not even CSS.
This is working fine but we're disabling it temporarily so we can test specific future changes in isolation without managing two separate branches.
There's always something...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.