fix(security): shell escape paths in HostDiskUsageService; null-prototype objects in batch parser#2659
Merged
KernelDeimos merged 3 commits intomainfrom Mar 13, 2026
Merged
Conversation
eac71cb to
76755c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security audit fixes for two findings:
HostDiskUsageService— paths passed todfviaexecSyncstring interpolation were unescaped. Replaced hand-rolled quoting withshescape(Shescape({ shell: 'bash', quote: true })), which also strips control characters that the previous implementation missed.routers/drivers/call.js— multipart field values parsed viaJSON.parseand spread ontoparamswithfor...inwere vulnerable to prototype pollution. Fixed by:Object.create(null)forparamsand all sub-objects created inon_fieldJSON.parsereviver that converts every parsed object to a null-prototype objectFindings reviewed but not changed
ProcessService—shell: trueLocalTerminalService— user-supplied args_default.js—allow_traversal: trueres.sendFile({ root })prevents user traversalsend-pass-recovery-email— user enumerationbatch/all.js—JSON.parsefor...inspreadputer.comroutes is an intentional mitigation strategyopener_originpostMessagetargetOrigin prevents spoofing to a different originKernel.js—shell: truewith npmTest plan
🤖 Generated with Claude Code