feat: add puter.peer to sdk, create PeerService in backend#2664
Merged
ProgrammerIn-wonderland merged 4 commits intoHeyPuter:mainfrom Mar 18, 2026
Merged
feat: add puter.peer to sdk, create PeerService in backend#2664ProgrammerIn-wonderland merged 4 commits intoHeyPuter:mainfrom
ProgrammerIn-wonderland merged 4 commits intoHeyPuter:mainfrom
Conversation
Collaborator
|
I think that there is some rigidity here that I don't fully like. I see that the stun URLs are hardcoded in puterjs. I think this should probably come from the signalling worker in some capacity so stun servers can be changed or TURN creds can be retrofitted/changed. The main reason for this is that once we deploy a version of puterjs, we support it pretty much indefinitely. This is why for example in the wisp service, the wisp URLs are given from the backend instead of being hardcoded in. |
Collaborator
|
I think a good example of what I want is basically what speed.cloudflare.com does in that the full webrtc config is sent from the server |
ProgrammerIn-wonderland
previously requested changes
Mar 16, 2026
Collaborator
|
otherwise, the actual core code seems pretty good and solid for the first iteration |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.