fix(gui): account for iOS safe area inset on taskbar/dock#2682
Conversation
The taskbar uses position:fixed with bottom:5px, which gets hidden behind the iOS Safari bottom toolbar on devices with home indicators. Use env(safe-area-inset-bottom) to push the dock above the safe area. The viewport-fit=cover meta tag is already present in initgui.js. Fixes #2517
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dock/taskbar is hidden behind the iOS Safari bottom toolbar on devices with home indicators (iPhone X+, newer iPads). The issue reports it "flashes when first visiting" and is "still clickable" but invisible.
Fix
Use
env(safe-area-inset-bottom)to push the dock above the iOS safe area:The
viewport-fit=covermeta tag is already present ininitgui.js(line 359), soenv()values are available. The0pxfallback ensures no change on non-iOS browsers.Fixes #2517