fix: remove desktop shortcut when app is deleted from Dev Center#2786
Open
tmchow wants to merge 1 commit intoHeyPuter:mainfrom
Open
fix: remove desktop shortcut when app is deleted from Dev Center#2786tmchow wants to merge 1 commit intoHeyPuter:mainfrom
tmchow wants to merge 1 commit intoHeyPuter:mainfrom
Conversation
After deleting an app via puter.apps.delete(), the .app shortcut file
on the user's desktop was not cleaned up. This left a non-functional
icon that could not be opened.
The cleanup attempts to delete /{username}/Desktop/{appTitle}.app
after the app deletion succeeds. If no shortcut exists (user never
added it to the desktop), the error is silently caught.
Fixes HeyPuter#766
|
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an app is deleted from the Dev Center, the
.appshortcut file on the user's desktop is not cleaned up. This leaves a non-functional icon that cannot be opened.Changes
In
src/dev-center/js/apps.js, theputer.apps.delete()success callback now also removes the desktop shortcut file at/{username}/Desktop/{appTitle}.app. The deletion is wrapped in a try/catch since the shortcut only exists if the user previously added it to their desktop via the Start menu context action.Steps to reproduce (before fix)
Testing
The cleanup runs after the existing app directory and subdomain cleanup (lines 1414-1423). If no shortcut file exists, the
puter.fs.deletecall throws and is silently caught.Fixes #766
This contribution was developed with AI assistance (Codex).