Block unconfirmed users from API endpoints server-side#2916
Merged
Conversation
Add a default-on email confirmation gate that rejects users with `requires_email_confirmation && !email_confirmed` on all authenticated routes, returning 403 with `email_confirmation_required`. Previously this was only enforced client-side via a GUI modal, meaning direct API calls could bypass the check entirely. Essential routes are exempted via `allowUnconfirmed: true`: `/whoami`, `/logout`, `/send-confirm-email`, `/confirm-email`, `/save_account`, `/get-anticsrf-token`, `/get-gui-token`, `/session/sync-cookie`, `/auth/revoke-session`, `/user-protected/delete-own-user` No impact on temp users (`requires_email_confirmation` is false), self-hosted deployments without email (flag is never set), or unauthenticated routes (login, signup, password recovery, OIDC). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a default-on email confirmation gate that rejects users with
requires_email_confirmation && !email_confirmedon all authenticated routes, returning 403 withemail_confirmation_required.Previously this was only enforced client-side via a GUI modal, meaning direct API calls could bypass the check entirely.
Essential routes are exempted via
allowUnconfirmed: true:/whoami,/logout,/send-confirm-email,/confirm-email,/save_account,/get-anticsrf-token,/get-gui-token,/session/sync-cookie,/auth/revoke-session,/user-protected/delete-own-userNo impact on temp users (
requires_email_confirmationis false), self-hosted deployments without email (flag is never set), or unauthenticated routes (login, signup, password recovery, OIDC).