feat (PUT-1025 PUT-1026 and PUT-1017): better handling old token auth required in gui#3166
Merged
Conversation
Salazareo
changed the title
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves session management and “old token reauth required” handling by enriching session metadata (IP/User-Agent + parent linkage), adding backend support for session label renaming, and upgrading the GUI’s Manage Sessions window with search, grouping, and new actions.
Changes:
- Backend: thread request IP/User-Agent through auth to
SessionStore.touch/updateActivity, persistlast_ip/last_user_agent, and expose them (plusparent_session_id) in/auth/list-sessions. - Backend: add session label rename support (
SessionStore.setLabel+AuthService.setSessionLabel+PATCH /auth/sessions/:uuid/label) with ownership enforcement and cache invalidation. - GUI: rebuild Manage Sessions UI with hierarchical display, search, revoke-all-others, per-row rename UI, and client label derived from User-Agent.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/gui/src/UI/UIWindowManageSessions.js | Adds session tree UI, search, rename, revoke-all-others, and UA-derived client labels. |
| src/backend/stores/session/SessionStore.test.ts | Adds tests for updateActivity IP/UA refresh and setLabel ownership behavior. |
| src/backend/stores/session/SessionStore.js | Implements setLabel and extends updateActivity/touch to persist IP/UA and invalidate caches. |
| src/backend/services/socket/SocketService.ts | Passes socket IP and User-Agent into auth so sessions can refresh roaming metadata. |
| src/backend/services/auth/AuthService.ts | Extends authenticate with request context, threads it into session resolution, exposes new session fields, and adds setSessionLabel. |
| src/backend/core/http/middleware/authProbe.ts | Passes request IP and User-Agent into authenticate for HTTP flows. |
| src/backend/controllers/auth/AuthController.ts | Adds PATCH /auth/sessions/:uuid/label route + handler for session renaming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+37
to
+39
| else if ( /Mac OS X/i.test(ua) ) os = 'macOS'; | ||
| else if ( /Android/i.test(ua) ) os = 'Android'; | ||
| else if ( /iPhone|iPad|iPod/i.test(ua) ) os = 'iOS'; |
Comment on lines
+491
to
+494
| el_search.addEventListener('input', () => { | ||
| searchQuery = el_search.value.trim(); | ||
| reload_sessions(); | ||
| }); |
Comment on lines
+145
to
+156
| const el_caret = document.createElement('span'); | ||
| el_caret.classList.add('session-widget-caret'); | ||
| el_caret.textContent = '▾'; | ||
| el_caret.style.cursor = 'pointer'; | ||
| el_caret.style.marginRight = '4px'; | ||
| el_caret.addEventListener('click', () => { | ||
| if ( !el_children_container ) return; | ||
| const collapsed = el_children_container.style.display === 'none'; | ||
| el_children_container.style.display = collapsed ? '' : 'none'; | ||
| el_caret.textContent = collapsed ? '▾' : '▸'; | ||
| }); | ||
| el_header.appendChild(el_caret); |
Comment on lines
+180
to
+185
| const el_rename_btn = document.createElement('span'); | ||
| el_rename_btn.classList.add('session-widget-rename'); | ||
| el_rename_btn.textContent = '✎'; | ||
| el_rename_btn.title = i18n('ui_rename') || 'Rename'; | ||
| el_rename_btn.style.cursor = 'pointer'; | ||
| el_rename_btn.style.opacity = '0.6'; |
Comment on lines
+1883
to
+1887
| await this.services.auth.setSessionLabel( | ||
| req.actor!, | ||
| uuid, | ||
| label ?? null, | ||
| ); |
Comment on lines
+239
to
+244
| el_input.addEventListener('keydown', (ev) => { | ||
| if ( ev.key === 'Enter' ) finish(true); | ||
| else if ( ev.key === 'Escape' ) finish(false); | ||
| }); | ||
| el_input.addEventListener('blur', () => finish(true)); | ||
| }; |
Salazareo
force-pushed
the
DS/put-1025-1026-1017
branch
2 times, most recently
from
c31a0bf to
9e024e6
Compare
Salazareo
force-pushed
the
DS/put-1025-1026-1017
branch
from
9e024e6 to
dea0dbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.