Skip to content

first preparation to enable multiple levels#523

Merged
SeverinDiederichs merged 4 commits into
Hi-PACE:developmentfrom
SeverinDiederichs:MR_preparation
Jun 10, 2021
Merged

first preparation to enable multiple levels#523
SeverinDiederichs merged 4 commits into
Hi-PACE:developmentfrom
SeverinDiederichs:MR_preparation

Conversation

@SeverinDiederichs
Copy link
Copy Markdown
Member

@SeverinDiederichs SeverinDiederichs commented Jun 9, 2021

This PR is a preparation for the upcoming implementation of mesh refinement.

It adds the ErrorEst function to tag the cells where the refinement is supported.
The lower and upper boundaries of the refined level can be read in via hipace.fine_tag_lo and hipace.fine_tag_hi.

The assert for lev = 0 is still in place and will be triggered if a simulation with max_level > 0 is started.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Copy link
Copy Markdown
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! See minor comments.

Comment thread docs/source/run/parameters.rst Outdated
Comment thread src/Hipace.cpp Outdated
Copy link
Copy Markdown
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, just saw something, I don't think this should be merged actually.

@SeverinDiederichs SeverinDiederichs merged commit f6d1f24 into Hi-PACE:development Jun 10, 2021
@SeverinDiederichs SeverinDiederichs deleted the MR_preparation branch June 10, 2021 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants