first preparation to enable multiple levels#523
Merged
SeverinDiederichs merged 4 commits intoJun 10, 2021
Conversation
MaxThevenet
approved these changes
Jun 9, 2021
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! See minor comments.
MaxThevenet
requested changes
Jun 9, 2021
Member
MaxThevenet
left a comment
There was a problem hiding this comment.
Hm, just saw something, I don't think this should be merged actually.
MaxThevenet
approved these changes
Jun 10, 2021
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for the upcoming implementation of mesh refinement.
It adds the
ErrorEstfunction to tag the cells where the refinement is supported.The lower and upper boundaries of the refined level can be read in via
hipace.fine_tag_loandhipace.fine_tag_hi.The assert for
lev = 0is still in place and will be triggered if a simulation withmax_level > 0is started.constisconst)