Skip to content

Update enforcePeriodic call (change in AMReX)#724

Closed
AlexanderSinn wants to merge 1 commit intoHi-PACE:developmentfrom
AlexanderSinn:fix_enforcePeriodic
Closed

Update enforcePeriodic call (change in AMReX)#724
AlexanderSinn wants to merge 1 commit intoHi-PACE:developmentfrom
AlexanderSinn:fix_enforcePeriodic

Conversation

@AlexanderSinn
Copy link
Copy Markdown
Member

See AMReX-Codes/amrex#2679

HiPACE++ doesn’t compile without this fix.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@MaxThevenet
Copy link
Copy Markdown
Member

Already included in #723, right? So I will close this PR (we can re-open it if needed).

1 similar comment
@MaxThevenet
Copy link
Copy Markdown
Member

Already included in #723, right? So I will close this PR (we can re-open it if needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants