Remove required from element #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to set step to be floating and all you need to do is not pass element prop.
|
Thanks @HiDeoo ! |
|
@lstaniszewski I'm on it, upgrading documentation to reflect your change 👍 |
|
Nice! Thanks. I will let myself do another PR if I find anything else to be more strict with intro.js. |
|
No problem, thanks for your contribution. Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
First great job with this project.
I'm using this in my project and I found out that it is possible to set step to be floating and all you need to do is not pass element prop, sadly you set element to required and I think it may be worth changing this.