Fix XSS, SSRF, and missing session verification#1081
Merged
daveearley merged 6 commits intodevelopfrom Mar 13, 2026
Merged
Conversation
- Fix broken null coalescing in UpdateEventSettingsHandler that prevented HtmlPurifier from ever running on non-null input - Add session verification to CompleteOrderHandler and TransitionOrderToOfflinePaymentHandler to match the pattern used by GetOrderPublicHandler and AbandonOrderPublicHandler - Add HtmlPurifier to CreateProductCategoryHandler and EditProductCategoryHandler for description field sanitization - Fix IPv4-mapped IPv6 bypass in NoInternalUrlRule (e.g. ::ffff:127.0.0.1) - Preserve null return from HtmlPurifierService::purify() for nullable fields - Update tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
post_checkout_message,pre_checkout_message,email_footer_message,offline_payment_instructions, andonline_event_connection_detailsGetOrderPublicHandlerandAbandonOrderPublicHandler::ffff:127.0.0.1,::ffff:169.254.169.254, etc.)nullinstead of''for null input to preserve nullable column semanticsTest plan
testRejectsIpv4MappedIpv6Addressescovers the SSRF bypassCompleteOrderHandlerTestupdated to include session mock