feat: Add environment variable to bypass NoInternalIP rule for specific webhook hosts#1122
Merged
daveearley merged 4 commits intoHiEventsDev:developfrom Mar 25, 2026
Merged
Conversation
…regardless of internal IP's (Optional for edge cases on selfhosted setups)
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
Thanks @MineTech13, We are also facing this issue as this validation currently blocks our deployment. We are sending webhooks via internal network. |
Contributor
|
Thanks for this addition @MineTech13! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Problem:
The recent security enhancements introduced the
NoInternalIPrule for webhooks. While this provides necessary security improvements, it limits deployments that intentionally route webhooks to internal services on the same network, such as self-hosted local bots.Proposed Solution:
This PR adds a configuration option to explicitly whitelist specific internal hosts or IP addresses, allowing them to bypass the
NoInternalIPrestriction.Changes Included:
APP_ALLOWED_INTERNAL_WEBHOOK_HOSTS) that accepts a comma-separated list of hosts or IPs.NoInternalIPvalidation rule to check against this variable. If a match is found, the restriction is skipped for that specific target.NoInternalIPrule applies to all internal addresses.Testing:
Checklist
I have read the CLA Document and I hereby sign the CLA