feat(webhooks): expose webhook signing secret on creation#1149
Merged
daveearley merged 4 commits intoHiEventsDev:developfrom Apr 7, 2026
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
8350779 to
f489f2d
Compare
Add WebhookResourceWithSecret that includes secret field. Use this in both event and organizer webhook create actions. Secret is only returned once on creation, excluded from other endpoints.
…eate DIsplay secret in modal with warning that it won't be shown again. Applies to both event and organizer webhook creation flows.
f489f2d to
7937fe3
Compare
Contributor
|
Nice PR! Thank you. Changes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes I've made
WebhookResourceWithSecretresource that extendsWebhookResourceto include the secret fieldCreateWebhookActionandCreateOrganizerWebhookActionto use this new resourceCreateWebhookModalandCreateOrganizerWebhookModalto display the signing secret after creation with a copy-to-clipboard button and a warning that it won't be shown againWhy I've made these changes
Fixes #1136
The webhook signing secret is auto-generated on creation but never exposed to the user. This makes it impossible for webhook consumers on the hosted cloud platform to verify webhook signatures, defeating the purpose of the HMAC signing mechanism.
How I've tested these changes
GET/list/editendpointsphp artisan test --testsuite=Unit)tsc --noEmit)Checklist