feat(android): improve sharing credential actions#31
feat(android): improve sharing credential actions#31AmirrezaFarnamTaheri wants to merge 1 commit into
Conversation
|
Thanks for the hard work on these improvements! The new sharing credential actions and the local IP display are great features that significantly enhance the user experience. However, given the large volume of changes in this PR, I have a couple of suggestions to ensure the long-term maintainability and robustness of the code: Reactive Network IP Updates: Currently, the local IP seems to be remembered only when the screen is first composed. If a user changes their network state (e.g., toggles Wi-Fi or enables a Hotspot) while the screen is open, the displayed IP will become stale. It would be better to monitor network changes and update the IP address dynamically. Could you please address these points? Once the logic is refactored and the IP display is more reactive, I'll be happy to review it again for merging. Thanks! |
Summary
Validation
git diff --checkgradle :app:compileDebugKotlinreaches Kotlin compilation but is blocked by the existing missing gomobilemobilepackage/AAR setup.