Fix CapioFile unlink bug and improve logging#207
Merged
GlassOfWhiskey merged 4 commits intomasterfrom Feb 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 56.13% 56.14% +0.01%
==========================================
Files 71 71
Lines 3481 3482 +1
Branches 2164 2165 +1
==========================================
+ Hits 1954 1955 +1
Misses 589 589
Partials 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5e86fdd to
a367b43
Compare
a367b43 to
e22b13d
Compare
Add TODO for supporting CLONE_FILES flag in _addNewFdToStorage
Fix typo in TODO comment regarding CLONE_FILES flag.
GlassOfWhiskey
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the
CapioFileclass that prevented a file from being correctly removed after anunlinkoperation.On the POSIX side, when a
clone()was issued, theCapioFile::clone()method was invoked for eachCapioFileinstance registered to the calling thread (tid).The issue was that
CapioFile::clone()always incremented_n_opens. As a result, even after all threads invokedclose()on the correspondingCapioFile, the internal open counter never reached zero, preventing the file from being deleted.CapioFile::clone()no longer increments_n_opensautomatically when a clone occurs. This ensures that the open counter accurately reflects the real number of active opens, allowing files to be properly removed afterunlinkonce all handles are closed.