Privatize CapioFile public class attributes#213
Merged
GlassOfWhiskey merged 4 commits intomasterfrom Mar 13, 2026
Merged
Conversation
472bb76 to
ddbb4eb
Compare
0e7f544 to
1607ce5
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #213 +/- ##
==========================================
+ Coverage 62.49% 62.50% +0.01%
==========================================
Files 76 76
Lines 3317 3334 +17
Branches 2046 2059 +13
==========================================
+ Hits 2073 2084 +11
+ Misses 954 435 -519
- Partials 290 815 +525 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CapioFile public class attributes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit further refactors methods in the
CapioFileclass to better reflect the logic that they implement. It also moves publicCapioFileattributes to private scope, exposing getter and setters for such attributes.