-
Notifications
You must be signed in to change notification settings - Fork 0
New state machine PR #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Maybe this will work? |
|
#10 needs to be merged before this. |
spellingcat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- delete elevator gravity from hoodio
- delete the isFull in indexer on L70
src/main/java/frc/robot/subsystems/shooter/ShooterSubsystem.java
Outdated
Show resolved
Hide resolved
| private Trigger feedReq; | ||
|
|
||
| @AutoLogOutput(key = "Superstructure/Flowstate Request") | ||
| private Trigger flowReq; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vivi is working on the flow stuff btw which i'll merge after this
spellingcat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm a little suspect of all the spinup stuff but like we're just gonna figure that out during testing so it's whatever. would you be so kind as to also update the markdown map? also have you tested this in sim
src/main/java/frc/robot/subsystems/shooter/ShooterSubsystem.java
Outdated
Show resolved
Hide resolved
|
|
||
| bindTransition(SuperState.FEED, SuperState.IDLE, isEmpty); | ||
| bindTransition( | ||
| SuperState.SPIN_UP, SuperState.SCORE, scoreReq.and(shooter::atFlywheelVelocitySetpoint)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should not debounce here but if we find we need to
spellingcat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 more thing
… getting stuck in a state)
No description provided.