Conversation
spellingcat
requested changes
Feb 9, 2026
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
spellingcat
requested changes
Feb 11, 2026
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
src/main/java/frc/robot/subsystems/shooter/TurretSubsystem.java
Outdated
Show resolved
Hide resolved
spellingcat
requested changes
Feb 11, 2026
spellingcat
reviewed
Feb 12, 2026
| this.sim = cancoder.getSimState(); | ||
| } | ||
|
|
||
| public void setSimValues(double positionRotations) { |
Member
There was a problem hiding this comment.
we might have to do the actual sim notifier thread but honestly i don't want to worry about that rn
spellingcat
approved these changes
Feb 12, 2026
| private final StatusSignal<Voltage> voltage = motor.getMotorVoltage(); | ||
| private final StatusSignal<Temperature> tempCelcius = motor.getDeviceTemp(); | ||
|
|
||
| private VoltageOut voltageOut = new VoltageOut(0.0).withEnableFOC(true); |
Member
There was a problem hiding this comment.
you need to also add the set voltage method but i'll just do it rn
| return rot; | ||
| } | ||
|
|
||
| //this should also adjust for like the turret offset from the robot rotation but like I don't know what that is |
Member
There was a problem hiding this comment.
yeah i need to think about this but we can do this during shot tuning
Member
|
merged in main in the fmt commit but forgot to name it correctly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.