This repository was archived by the owner on Apr 8, 2026. It is now read-only.
Align SkyHook event types/labels with external SkyHook API and fix consumer event type references#3
Merged
2228293026 merged 2 commits intoMar 7, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
SkyHookdefinitions forEventTypeandKeyLabeland avoid type ambiguities.SkyHooktypes.Description
EventTypeandKeyLabelenums and switched to usingglobal::SkyHook.EventTypeandglobal::SkyHook.KeyLabelthroughout the compatibility layer and consumer code.SkyHookEventlayout: removedFlagsandExtraInfofields, addedGetTimeInTicks()helper, and adjustedCreateto acceptelapsedTicksin 100ns units and produceTimeSec/TimeSubsecNano.ConvertTicksToSkyHookTimeand corrected the mapping logic in the key-label lookup via a switch expression returningglobal::SkyHook.KeyLabel.AsyncInputManagerhot paths toglobal::SkyHook.EventTypeto avoid ambiguous references and ensure the JIT-warmed paths use the correct types.INPUT/KEYBDINPUT/MOUSEINPUT/HARDWAREINPUTinterop structs to the compatibility file and removed unused usings.Testing
dotnet buildand the build completed successfully.dotnet testand all automated tests passed.SkyHookenums without ambiguity.Codex Task