Add custom dimension mapping#2024
Merged
clankstar merged 11 commits intoHiveGamesOSS:developfrom Apr 9, 2026
Merged
Conversation
FormallyMyles
requested changes
Mar 5, 2026
Collaborator
FormallyMyles
left a comment
FormallyMyles
left a comment
There was a problem hiding this comment.
Initial review from just reading the code:
- I'd replace usages of
varwith the type to keep it consistent with the rest of Chunker. - If it's within scope I'd make a JSON schema in
app/ui/public/schemas/custom_dimensions.schema.jsonjust to keep the documentation in line with our other stuff (the directory has examples for stuff like pruning).
Otherwise most of the comments are just keeping the documentation inline with what we already have.
FormallyMyles
requested changes
Mar 6, 2026
Collaborator
FormallyMyles
left a comment
FormallyMyles
left a comment
There was a problem hiding this comment.
Minor comments but otherwise the code is looking good
FormallyMyles
requested changes
Mar 11, 2026
FormallyMyles
requested changes
Mar 11, 2026
FormallyMyles
requested changes
Mar 26, 2026
Collaborator
FormallyMyles
left a comment
FormallyMyles
left a comment
There was a problem hiding this comment.
Few last minor comments
added 8 commits
March 27, 2026 14:28
Add custom dimension schema
Remove required numbering of dimensions in mappings.
FormallyMyles
requested changes
Mar 29, 2026
Collaborator
FormallyMyles
left a comment
FormallyMyles
left a comment
There was a problem hiding this comment.
Feedback from the rebase
FormallyMyles
requested changes
Apr 1, 2026
FormallyMyles
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a Dimension registry with default definitions for built in dimensions.
Add a dimension mapping file to allow adding your own custom definition for mapping.