Skip to content

remove ruff excludes and fix existing lint issues#18

Merged
tylerlu-hivemapper merged 1 commit intomainfrom
lint-the-whole-codebase
Apr 7, 2026
Merged

remove ruff excludes and fix existing lint issues#18
tylerlu-hivemapper merged 1 commit intomainfrom
lint-the-whole-codebase

Conversation

@tylerlu-hivemapper
Copy link
Copy Markdown
Contributor

@tylerlu-hivemapper tylerlu-hivemapper commented Apr 7, 2026

Summary

  • Remove ruff lint excludes for all Python files (kept only fixtures/ since its just images)
  • Apply safe auto-fixes across 12 files: import sorting, unused import removal, trailing semicolon, unnecessary f-prefix, redundant open() mode arg, unused variable names
  • Add from e exception chaining in secrets.py (3 raises, stack trace only — no runtime behavior change)
  • Suppress existing F821 bug in image_cache.py with noqa (pre-existing, out of scope) since itd change runtime behavior

Test plan

  • ruff check . passes clean
  • All 8 tests pass
  • All changes are cosmetic or stack-trace-only — no runtime behavior changes

@tylerlu-hivemapper tylerlu-hivemapper merged commit f41782b into main Apr 7, 2026
1 check passed
@tylerlu-hivemapper tylerlu-hivemapper deleted the lint-the-whole-codebase branch April 7, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants