fix(tui): reset displayed cost on clear#1796
Closed
LING71671 wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request expands the session clearing logic in the TUI to include subagent costs and cost high-water marks, along with updated test coverage. The review feedback points out that certain telemetry fields are still missing from the reset process and suggests including them. Furthermore, it recommends replacing manual field assignments with Default::default() to ensure the session state is fully and maintainably reset.
Owner
Contributor
Author
|
Thanks for harvesting this into v0.8.40 and for the release-branch closeout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/clearresets the conversation session./clear./cleartelemetry coverage to assert sub-agent cost, high-water state, anddisplayed_session_cost()are zeroed.Closes #1788
Verification
cargo fmt --all -- --checkgit diff --checkcargo test -p deepseek-tui --bin deepseek-tui test_clear_resets_all_statecargo test -p deepseek-tui --bin deepseek-tui clear_resets_session_telemetryNotes
cargo clippy --workspace --all-targets --all-features -- -D warningswas attempted, but currentupstream/mainfails on pre-existing warnings unrelated to this change: dead-code warnings incrates/tui/src/schema_migration.rsandclippy::needless_returnincrates/tui/src/tui/ui.rs.