fix(tui): make subagent api timeout configurable#1808
Closed
LING71671 wants to merge 2 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a configurable per-step model API timeout for sub-agents, including configuration updates, runtime propagation, and documentation. The reviewer suggests enforcing a minimum timeout of 1 second to prevent configuration errors and ensuring that all documentation and tests consistently reflect the valid range of 1 to 1800 seconds.
11 tasks
Owner
Contributor
Author
|
Thanks for harvesting this into v0.8.40. Glad the subagent timeout work made it into the release branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1806.
This PR makes the sub-agent per-step model API timeout configurable without changing the legacy default:
[subagents] api_timeout_secsEngineConfigintoSubAgentRuntimecreate_messagecalldocs/CONFIGURATION.mdanddocs/SUBAGENTS.mdScope
This intentionally implements the minimal timeout-control fix from the issue. It does not change sub-agent tool permissions, write access, streaming, or checkpoint behavior.
Validation
Passed:
cargo fmt --all -- --checkgit diff --checkcargo check -p deepseek-tui --bin deepseek-tuicargo test -p deepseek-tui --bin deepseek-tui subagent_api_timeout_defaults_to_legacy_120scargo test -p deepseek-tui --bin deepseek-tui subagent_api_timeout_only_clamps_to_maximumcargo test -p deepseek-tui --bin deepseek-tui child_runtime_preserves_api_timeoutcargo test -p deepseek-tui --bin deepseek-tui subagent_runtime_default_api_timeout_is_legacy_120scargo test -p deepseek-tui --bin deepseek-tui tools::subagent::tests::cargo buildcargo clippy --workspace --all-targets --all-featuresNotes:
cargo build/cargo clippystill report pre-existing warnings inschema_migration.rs.cargo clippyalso still reports the pre-existingneedless_returnwarnings intui/ui.rs.