feat(execpolicy): add typed permission rules and config schema#2046
Open
greyfreedom wants to merge 10 commits into
Open
feat(execpolicy): add typed permission rules and config schema#2046greyfreedom wants to merge 10 commits into
greyfreedom wants to merge 10 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request implements a granular tool permission system, introducing typed rules for tool names, command prefixes, and path globs while maintaining legacy compatibility. Feedback focuses on performance optimizations for rule resolution and glob matching, refining denial logic to prevent over-blocking, and improving configuration merging to allow overriding global lists with empty ones.
3 tasks
This was referenced May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased replacement for #1189 on current
mainafter the v0.8.41 CodeWhale rebrand.Summary
allow,deny, andaskdecisions.exec_shellcommand-prefix matching and workspace-relative path glob matching.auto_allow/auto_denyconfig lists.globsetfor glob evaluation.Validation
cargo fmt --allcargo test -p codewhale-execpolicy -p codewhale-config -p codewhale-app-server -p codewhale-cli --all-featurescargo test -p codewhale-tui pandoc_convert_rejects_inline_request_for_binary_format --all-featurescargo test -p codewhale-tui execute_rejects_absolute_path --all-featurescargo test -p codewhale-tui tasks_panel_collapses_stale_running_tool_rows --all-featurescargo clippy -p codewhale-execpolicy -p codewhale-config -p codewhale-app-server -p codewhale-cli --all-targets --all-features -- -D warnings